Re: [Jfs-discussion] [PATCH] fs: cleanup slight list_entry abuse

[Dave Kleikamp]

On 03/19/2015 11:11 AM, Boaz Harrosh wrote:
> On 03/19/2015 01:28 PM, Rasmus Villemoes wrote:
>> list_entry is just a wrapper for container_of, but it is arguably
>> wrong (and slightly confusing) to use it when the pointed-to struct
>> member is not a struct list_head. Use container_of directly instead.
>>
>> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
>> ---
>> Most of these predate git. If I'm the only one who has been confused
>> by this in 10 years, maybe it's not worth the churn.
>>
> 
> No you are not alone here. I have seen this once as well but did not have
> the gumption to send a fix. (The sysv.h one)
> 
> I totally agree with this patch. (So many of them, bread crumbs of copy/paste
> for you ;0)

I'm sure that was the case with jfs.

> 
> Reviewed-by: Boaz Harrosh <boaz@xxxxxxxxxxxxx>

Acked-by: Dave Kleikamp <dave.kleikamp@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/