Re: [PATCH] x86, mce, severities: Add AMD severities function

[Aravind Gopalakrishnan]

On 3/19/2015 4:29 AM, Borislav Petkov wrote:
> On Thu, Mar 19, 2015 at 12:01:32AM +0000, Luck, Tony wrote:
> > One other thought.  Instead of the run-time test to see if this is an AMD processor on every call
> > to this function, would it be cleaner to:
> >
> > 1) Rename existing mce_severity() function to mce_severity_intel()
> > 2) Declare a function pointer named mce_severity.
> > 3) Assign that pointer to the _intel() or _amd() function in mce_init()
> Yes, of course. We do that (or at least pretty close) in other paths
> too.

Ok, I'll work on this and prepend the changes to the current version of 
the patch.
Would you prefer the changes be in a separate patch or lump it in along 
with current version?

Thanks,
-Aravind.




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/