Re: [PATCH V2 7/8] ARM: cpuidle: Register per cpuidle device

[Lorenzo Pieralisi]

On Thu, Mar 19, 2015 at 11:27:20AM +0000, Daniel Lezcano wrote:

[...]

> >>   	for_each_possible_cpu(cpu) {
> >>   		ret = arm_cpuidle_init(cpu);
> >> +
> >> +		/* This cpu does not support any idle states */
> >> +		if (ret == -ENOSYS)
> >> +			continue;
> >> +
> >>   		if (ret) {
> >>   			pr_err("CPU %d failed to init idle CPU ops\n", cpu);
> >> -			return ret;
> >> +			goto out_fail;
> >> +		}
> >> +
> >> +		dev = kzalloc(sizeof(*dev), GFP_KERNEL);
> >> +		if (!dev) {
> >> +			pr_err("Failed to allocate cpuidle device\n");
> >> +			goto out_fail;
> >> +		}
> >> +
> >> +		dev->cpu = cpu;
> >> +		per_cpu(cpuidle_arm_dev, cpu) = dev;
> >> +
> >> +		ret = cpuidle_register_device(dev);
> >> +		if (ret) {
> >> +			pr_err("Failed to register cpuidle device for CPU %d\n",
> >> +			       cpu);
> >> +			kfree(dev);
> >> +			goto out_fail;
> >>   		}
> >>   	}
> >> +out:
> >> +	return ret;
> >
> > return 0;
> >
> >>
> >> -	return cpuidle_register(drv, NULL);
> >> +out_fail:
> >> +	for (cpu--; cpu <= 0; cpu--) {
> >
> > This loop is wrong.
> 
> Why is it wrong ? We have to initialize at cpu - 1 to unregister the 
> previous registered cpu, not the current one, no ?

Yes, but on cpu>=0 not cpu<=0

while (--cpu >= 0)

?

Lorenzo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/