Re: [PATCH v2] add support for Freescale's MMA8653FC 10 bit accelerometer

From: Alexander Stein
Date: Wed Mar 18 2015 - 12:21:16 EST


On Wednesday 18 March 2015 16:55:57, Martin Kepplinger wrote:
> From: Martin Kepplinger <martin.kepplinger@xxxxxxxxxxxxxxxxxxxxx>
>
> The MMA8653FC is a low-power, three-axis, capacitive micromachined
> accelerometer with 10 bits of resolution with flexible user-programmable
> options.
>
> Embedded interrupt functions enable overall power savings, by relieving the
> host processor from continuously polling data, for example using the poll()
> system call.
>
> The device can be configured to generate wake-up interrupt signals from any
> combination of the configurable embedded functions, enabling the MMA8653FC
> to monitor events while remaining in a low-power mode during periods of
> inactivity.
>
> This driver provides devicetree properties to program the device's behaviour
> and a simple, tested and documented sysfs interface. The data sheet and more
> information is available on Freescale's website.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@xxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Christoph Muellner <christoph.muellner@xxxxxxxxxxxxxxxxxxxxx>
> ---
> applies to v4.0-rc4 and the current -next.
>
> patch revision history
> ......................
> v2 corrects licensing and commit messages and adds appropriate recipients
>
> .../testing/sysfs-bus-i2c-devices-fsl-mma8653fc | 39 +
> .../devicetree/bindings/misc/fsl,mma8653fc.txt | 96 +++
> MAINTAINERS | 5 +
> drivers/input/misc/Kconfig | 11 +
> drivers/input/misc/Makefile | 1 +
> drivers/input/misc/mma8653fc.c | 913 +++++++++++++++++++++
> 6 files changed, 1065 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-i2c-devices-fsl-mma8653fc
> create mode 100644 Documentation/devicetree/bindings/misc/fsl,mma8653fc.txt
> create mode 100644 drivers/input/misc/mma8653fc.c

Shouldn't this go to drivers/iio/magnetometer instead of defining a new sysfs ABI?

Best regards,
Alexander
--
Dipl.-Inf. Alexander Stein

SYS TEC electronic GmbH
Am Windrad 2
08468 Heinsdorfergrund
Tel.: 03765 38600-1156
Fax: 03765 38600-4100
Email: alexander.stein@xxxxxxxxxxxxxxxxxxxxx
Website: www.systec-electronic.com

Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Chemnitz, HRB 28082

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/