Re: [PATCH] ACPI / sleep: Drop acpi_suspend() which is not used

From: Hanjun Guo
Date: Tue Mar 17 2015 - 21:17:49 EST


On 2015/3/17 22:29, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> The acpi_suspend() function has no callers, so drop it.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

Reviewed-by: Hanjun Guo <hanjun.guo@xxxxxxxxxx>

> ---
> drivers/acpi/sleep.c | 15 ---------------
> drivers/acpi/sleep.h | 2 --
> 2 files changed, 17 deletions(-)
>
> Index: linux-pm/drivers/acpi/sleep.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/sleep.c
> +++ linux-pm/drivers/acpi/sleep.c
> @@ -806,21 +806,6 @@ static void acpi_sleep_hibernate_setup(v
> static inline void acpi_sleep_hibernate_setup(void) {}
> #endif /* !CONFIG_HIBERNATION */
>
> -int acpi_suspend(u32 acpi_state)
> -{
> - suspend_state_t states[] = {
> - [1] = PM_SUSPEND_STANDBY,
> - [3] = PM_SUSPEND_MEM,
> - [5] = PM_SUSPEND_MAX
> - };
> -
> - if (acpi_state < 6 && states[acpi_state])
> - return pm_suspend(states[acpi_state]);
> - if (acpi_state == 4)
> - return hibernate();
> - return -EINVAL;
> -}
> -
> static void acpi_power_off_prepare(void)
> {
> /* Prepare to power off the system */
> Index: linux-pm/drivers/acpi/sleep.h
> ===================================================================
> --- linux-pm.orig/drivers/acpi/sleep.h
> +++ linux-pm/drivers/acpi/sleep.h
> @@ -1,6 +1,4 @@
>
> -extern int acpi_suspend(u32 state);
> -
> extern void acpi_enable_wakeup_devices(u8 sleep_state);
> extern void acpi_disable_wakeup_devices(u8 sleep_state);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> .
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/