Re: [PATCH] printk: Use symbolic defines for console loglevels instead of numbers

From: Alexander Kuleshov
Date: Tue Mar 17 2015 - 06:59:34 EST


2015-03-16 21:09 GMT+06:00 Joe Perches <joe@xxxxxxxxxxx>:
> On Mon, 2015-03-16 at 15:01 +0600, Alexander Kuleshov wrote:
>> Signed-off-by: Alexander Kuleshov <kuleshovmail@xxxxxxxxx>
>
> Perhaps the entries for #define CONSOLE_LOGLEVEL_<FOO>
> from printk.h and #define LOGLEVEL_<FOO> from kern_levels.h
> can be consolidated and rationalized as well.
>
>

Hello Joe,

yes good idea. What was the purpose of adding LOGLEVEL_<FOO> macro? I see
that CONSOLE_LOGLEVEL_<FOO> were added earlier. what if we remove LOGLEVL_<FOO>
macro and add/adapt missing as CONSOLE_LOGLEVEL_<FOO>, like
CONSOLE_LOGLEVEL_SCHED and etc...?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/