Re: [PATCH v2] pinctrl: tegra: use signed bitfields for optional fields

[Stephen Warren]

On 03/16/2015 03:42 PM, Stefan Agner wrote:
> Optional fields are set to -1 by various preprocessor macros. Make
> sure the fields can actually store them.

This seems fine to me. I suppose there is a small risk that the old code 
let some invalid configurations pass whereas this new code will reject 
them and hence not program any later pinmux configurations in the "list" 
in DT. However, I suspect the risk is quite small and won't be an issue.

Acked-by: Stephen Warren <swarren@xxxxxxxxxx>

I also tested this on Beaver, Dalmore, and Jetson TK1 using Paul 
Walmsley's automated test system, and saw no issues, so:

Tested-by: Stephen Warren <swarren@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/