Re: [PATCH] leds: Add arbitrary pattern trigger

From: Pavel Machek
Date: Mon Mar 16 2015 - 08:20:41 EST


Hi!

I'd really return error if we can't parse user's input.

Small spelling fixes:

--- drivers/leds/trigger/ledtrig-pattern.c~ 2015-03-16 12:07:06.897408622 +0100
+++ drivers/leds/trigger/ledtrig-pattern.c 2015-03-16 13:08:25.801864534 +0100
@@ -38,7 +38,7 @@
int nsteps; /* Number of steps */
int repeat; /* < 0 means repeat indefinitely */
struct timer_list timer; /* Used for scheduling updates to
- the led brightness */
+ the LED brightness */
};

#define MAX_NSTEPS (PAGE_SIZE/4)
@@ -84,7 +84,7 @@

/*
* is_sane : pattern checking.
- * A pattern satisfaying these three conditions is reported as sane :
+ * A pattern satisfying these three conditions is reported as sane :
* - At least two steps
* - At least one step with time >= UPDATE_INTERVAL
* - At least two steps with differing brightnesses


--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/