Re: [PATCH 2/2] rtc: add rtc-abx80x, a driver for the Abracon AB x80x i2c rtc

From: Paul Bolle
Date: Mon Mar 16 2015 - 06:16:29 EST


On Sat, 2015-03-14 at 13:44 +0100, Philippe De Muyter wrote:
> On Sat, Mar 14, 2015 at 11:05:46AM +0100, Alexandre Belloni wrote:
> > --- /dev/null
> > +++ b/drivers/rtc/rtc-abx80x.c
> > +/*
> > + * A driver for the I2C members of the Abracon AB x8xx RTC family,
> > + * and compatible: AB 1805 and AB 0805
> > + *
> > + * Copyright 2014-2015 Macq S.A.
> > + *
> > + * Author: Philippe De Muyter <phdm@xxxxxxxxx>
> > + * Author: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + *
> > + */
> >
> > +MODULE_LICENSE("GPL");
>
> I'm fine with 'GPL', but someone suggested to change that to 'GPL v2' in my patch.

That someone was me. And my reasoning is that "GPL" is documented to
mean "GPL v2 or later", while "GPL v2" is documented to mean just that.
So "GPL v2" would match what is stated at the comment at the top of this
file.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/