[patch 1/2] extcon: max77843: signedness bug in max77843_muic_set_debounce_time()

From: Dan Carpenter
Date: Sun Mar 15 2015 - 06:50:07 EST


"ret" holds negative error codes and zero so it should be signed.

Fixes: 27a28d32b4f2 ('extcon: max77843: Add max77843 MUIC driver')
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
index 598a017..a3f80ca 100644
--- a/drivers/extcon/extcon-max77843.c
+++ b/drivers/extcon/extcon-max77843.c
@@ -682,7 +682,7 @@ static int max77843_muic_set_debounce_time(struct max77843_muic_info *info,
enum max77843_muic_adc_debounce_time time)
{
struct max77843 *max77843 = info->max77843;
- unsigned int ret;
+ int ret;

switch (time) {
case MAX77843_DEBOUNCE_TIME_5MS:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/