Re: [PATCH 3/4] netfilter: Fix portid types

[Pablo Neira Ayuso]

On Fri, Mar 13, 2015 at 12:31:15PM +0100, Richard Weinberger wrote:
> The netlink portid is an unsigned integer, use this type
> also in netfilter.

This small cleanup I can still take it but...

> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
>  net/netfilter/nfnetlink_log.c        | 4 ++--
>  net/netfilter/nfnetlink_queue_core.c | 7 ++++---
>  2 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
> index 11d85b3..7f00846 100644
> --- a/net/netfilter/nfnetlink_log.c
> +++ b/net/netfilter/nfnetlink_log.c
> @@ -62,7 +62,7 @@ struct nfulnl_instance {
>  	struct timer_list timer;
>  	struct net *net;
>  	struct user_namespace *peer_user_ns;	/* User namespace of the peer process */
> -	int peer_portid;			/* PORTID of the peer process */
> +	unsigned int peer_portid;		/* PORTID of the peer process */

I think you have to use u32 for consistency. Other spots use the
datatype for the netlink portid.

I think same thing applies to other patches.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/