Re: [PATCH] rtlwifi: get buffer_desc before trying to alloc new skb

From: Yang Bai
Date: Thu Mar 12 2015 - 22:36:58 EST


On Fri, Mar 13, 2015 at 1:29 AM, Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote:
> On 03/12/2015 06:33 AM, Yang Bai wrote:
>>
>> if rtlpriv->use_new_trx_flow == true and we run out of memory
>> to alloc a new skb, we will directly jump to no_new tag with
>> buffer_desc == NULL. Then we will dereference this NULL pointer
>> in function _rtl_pci_init_one_rxdesc.
>>
>> Signed-off-by: Yang Bai <hamo.by@xxxxxxxxx>
>
>
> Is the attached patch OK? I have tested it, but it is unlikely that I have
> hit any memory failures, thus that part needs to be checked by eye.

Looks good to me. Thanks very much for your review.

Yang
>
> Larry
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/