Re: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

From: Matt Fleming
Date: Thu Mar 12 2015 - 18:48:05 EST


On Tue, 10 Mar, at 08:51:59AM, Andy Lutomirski wrote:
>
> I'm not 100% happy with write(2) (which is all we have in sysfs) for
> two reasons:
>
> 1. If we write a file name, eww. That's more complicated, requires
> temporary files, has annoying mount namespace issues, etc.
>
> 2. If we write the full contents, we need to do it in a single call to
> write. That means that we can't use cat, which mostly defeats the
> purpose. In fact, using cat could be actively harmful.

At this point I'd really like Greg to chime in.

In principal, I'm not stricly opposed to using a simple char device
provided that it's not essentially a copy and paste of code from
drivers/base/firmware_class.c.

Greg?

--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/