Re: [PATCH v4] x86: Fix sibling map with NumaChip

From: Borislav Petkov
Date: Thu Mar 12 2015 - 10:51:34 EST


On Thu, Mar 12, 2015 at 12:52:30PM +0800, Daniel J Blueman wrote:
> On NumaChip systems, the physical processor ID assignment wasn't accounting
> for the number of nodes in AMD multi-module processors, giving an incorrect
> sibling map:
>
> $ cd /sys/devices/system/cpu/cpu29/topology
> $ grep . *
> core_id:5
> core_siblings:00000000,ff000000
> core_siblings_list:24-31
> physical_package_id:3
> thread_siblings:00000000,30000000
> thread_siblings_list:28-29
>
> After fixing:
>
> core_id:5
> core_siblings:00000000,ffff0000
> core_siblings_list:16-31
> physical_package_id:1
> thread_siblings:00000000,30000000
> thread_siblings_list:28-29
>
> v2: Fix to check for MSR availability before use, as per Boris's feedback
> v3: Test against boot cpu to correct behaviour on larger systems with global IO
> v4: Use static_cpu_has_safe(), as Boris suggests
>
> Candidate for stable.
>
> Signed-off-by: Daniel J Blueman <daniel@xxxxxxxxxxxxx>
> ---
> arch/x86/kernel/apic/apic_numachip.c | 22 ++++++++++++++++------
> 1 file changed, 16 insertions(+), 6 deletions(-)

Queued for urgent/stable.

Thanks.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/