Re: [PATCH 2/3] Staging: dgnc: Use goto for error handling

From: Quentin Lambert
Date: Thu Mar 12 2015 - 05:32:49 EST




On 12/03/2015 10:27, Dan Carpenter wrote:
On Wed, Mar 11, 2015 at 06:37:30PM +0200, Giedrius StatkeviÄius wrote:
It's still not in staging-testing for some reason :(

It can take several weeks to get merged. Relax.

regards,
dan carpenter

What should i do concerning that ?
I need to send a second version of this patch anyway to fix the
fact that i inverted 2 statements, namely:

+exit_unlock:
+ if (ld)
+ tty_ldisc_deref(ld);
+ spin_unlock_irqrestore(&ch->ch_lock, flags);

should be

+exit_unlock:
+ spin_unlock_irqrestore(&ch->ch_lock, flags);
+ if (ld)
+ tty_ldisc_deref(ld);

Should I wait these several weeks to send the second version or should
I send a second version fixing this issue a wait for someone to ask me
to solve the conflict ?

Quentin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/