Re: [RFC 5/6] drm/imx: Remove local fbdev emulation Kconfig option

[Archit Taneja]

On 03/10/2015 04:24 PM, Philipp Zabel wrote:
> Hi Archit,
>
> thanks for the cleanup!
>
> Am Dienstag, den 10.03.2015, 15:11 +0530 schrieb Archit Taneja:
> > DRM_IMX_FB_HELPER config is currently used to enable/disable fbdev emulation for
> > the imx kms driver.
> >
> > Remove this local config option and use the top level DRM_FBDEV_EMULATION config
> > option where applicable. Using this config lets us also prevent wrapping around
> > drm_fb_helper_* calls with #ifdefs in certain places.
> >
> > We replace the #ifdef in imx_drm_driver_load with CONFIG_DRM_FBDEV_EMULATION.
> > It's probably okay to get remove the #ifdef itself, but just left it here for
> > now to be safe. It can be removed after some testing.
> >
> > Signed-off-by: Archit Taneja <architt@xxxxxxxxxxxxxx>
>
> Tested-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> (Both with and without the #ifdef CONFIG_DRM_FBDEV_EMULATION removed.)

Thanks for testing it out.

> Although this is for another patch, I think the legacyfb_depth
> module_param should be removed altogether if CONFIG_DRM_FBDEV_EMULATION
> is disabled, so maybe that #ifdef should stay.

I'll create a patch for that for future revs of this patch set.

Archit

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/