Re: [PATCH 2/9] selftests: Add install target

From: Michael Ellerman
Date: Tue Mar 10 2015 - 23:15:18 EST


On Thu, 2015-03-05 at 13:53 -0500, Dave Jones wrote:
> On Tue, Mar 03, 2015 at 03:51:35PM +1100, Michael Ellerman wrote:
> > This adds make install support to selftests. The basic usage is:
> >
> > $ cd tools/testing/selftests
> > $ make install
> >
> > That installs into tools/testing/selftests/install, which can then be
> > copied where ever necessary.
> >
> > The install destination is also configurable using eg:
> >
> > $ INSTALL_PATH=/mnt/selftests make install
>
> ...
>
> > + @# Ask all targets to emit their test scripts
> > + echo "#!/bin/bash\n\n" > $(ALL_SCRIPT)
>
> $ ./all.sh
> -bash: ./all.sh: /bin/bash\n\n: bad interpreter: No such file or directory
>
> Removing the \n\n fixes it.
>
> > + echo "cd \$$ROOT\n" >> $(ALL_SCRIPT); \
>
> ditto

Weird, I don't see that.

$ make install
$ head install/run_kselftest.sh
#!/bin/bash


cd $(dirname $0)


Does it depend on the shell? I guess none of the newlines are necessary so I'll
just remove them.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/