Re: [PATCH 43/45] include/uapi/linux/netfilter_bridge.h: include if.h

From: Mikko Rapeli
Date: Tue Mar 10 2015 - 21:50:04 EST


On Tue, Feb 17, 2015 at 01:02:50AM +0100, Jan Engelhardt wrote:
> On Tuesday 2015-02-17 00:05, Mikko Rapeli wrote:
>
> >Fixes userspace compilation errors like:
> >
> >error: field âinâ has incomplete type
> >struct in_addr in;
> >
> >+#include <linux/if.h>
>
> Patch 36/45 included linux/in.h instead of linux/if.h for addressing "in has incomplete
> type". Should this be used here too?

It could, yes. It seems I cut some corners since this was hiding behind it:

In file included from ./linux/netfilter_bridge.h:11:0,
from ./linux/netfilter_bridge.c:1:
./linux/if_pppox.h:42:11: error: âIFNAMSIZâ undeclared here (not in a function)
char dev[IFNAMSIZ]; /* Local device to use */

I'll fix these.

-Mikko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/