Re: [PATCH] x86: svm: make wbinvd faster

From: Marcelo Tosatti
Date: Tue Mar 10 2015 - 18:37:59 EST


On Tue, Mar 10, 2015 at 12:01:31PM +0100, Radim KrÄmÃÅ wrote:
> 2015-03-09 20:28-0300, Marcelo Tosatti:
> > On Fri, Feb 27, 2015 at 06:19:18PM -0600, Joel Schopp wrote:
> > > From: David Kaplan <David.Kaplan@xxxxxxx>
> > > No need to re-decode WBINVD since we know what it is from the intercept.
> > >
> > > Signed-off-by: David Kaplan <David.Kaplan@xxxxxxx>
> > > [extracted from larger unlrelated patch, forward ported, tested]
> > > Signed-off-by: Joel Schopp <joel.schopp@xxxxxxx>
> >
> > Can't you disable the intercept if need_emulate_wbinvd(vcpu) == false?
>
> I don't think we want to: it should be faster to intercept and ignore
> than to invalidate all caches. The exit doesn't affect other physical
> cores and costs just about 10(?) L3 cache misses.

Yes, right.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/