Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

From: Yinghai Lu
Date: Tue Mar 10 2015 - 15:30:00 EST


On Tue, Mar 10, 2015 at 8:48 AM, Borislav Petkov <bp@xxxxxxx> wrote:
> On Tue, Mar 10, 2015 at 08:42:40AM -0700, Yinghai Lu wrote:
>> In arch/x86/boot/header.S, we already use VO and ZO.
>> So please keep on using them, and don't introduce "kernel proper" etc.
>
> So you're suggesting commit messages should use variable names and
> prefixes from the code instead of being human-readable?

Now we have
vmlinux ===> VO or kernel, that is output/init_size in misc.c
arch/x86/boot/compressed/vmlinux.bin.xz ==> compressed kernel. that
is input/input_len in misc.c
arch/x86/boot/compressed/vmllinux ==> ZO,
arch/x86/boot/setup + ZO is bzImage.

I really think we should not use
"compressed kernel" for arch/x86/boot/compressed/vmlinux
that should stand for compressed vmlinux.

VO/ZO should be better thatn "kernel proper"/'compressed kernel"
for vmlinux/"arch/x86/boot/compressed/vmlinux" ?

Peter/Ingo, How to you think about that?

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/