Re: [PATCH v2 07/18] drivers: reset: Add STM32 reset driver

From: Arnd Bergmann
Date: Tue Mar 10 2015 - 11:03:01 EST


On Friday 20 February 2015 19:01:06 Maxime Coquelin wrote:
> +/* AHB1 */
> +#define GPIOA_RESET 0
> +#define GPIOB_RESET 1
> +#define GPIOC_RESET 2
> +#define GPIOD_RESET 3
> +#define GPIOE_RESET 4
> +#define GPIOF_RESET 5
> +#define GPIOG_RESET 6
> +#define GPIOH_RESET 7
> +#define GPIOI_RESET 8
> +#define GPIOJ_RESET 9
> +#define GPIOK_RESET 10
>

As these are just the hardware numbers, it's better to not make them
part of the binding at all. Instead, just document in the binding that
one is supposed to pass the hardware number as the argument.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/