Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750

From: Dan Carpenter
Date: Tue Mar 10 2015 - 07:40:56 EST


On Tue, Mar 10, 2015 at 09:57:06AM +0000, Lorenzo Stoakes wrote:
> This patch assigns the more appropriate void* type to the mmio750 variable
> eliminating an unnecessary volatile qualifier in the process. Additionally it
> updates parameter types as necessary where those parameters interact with
> mmio750 and removes unnecessary casts.
>
> As a consequence, this patch fixes the following sparse warning:-
>
> drivers/staging/sm750fb/ddk750_help.c:12:17: warning: incorrect type in assignment (different address spaces)
>
> Signed-off-by: Lorenzo Stoakes <lstoakes@xxxxxxxxx>

Looks good. Thanks for doing this.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/