Re: [PATCH] sunrpc: fix braino in ->poll()

From: J. Bruce Fields
Date: Mon Mar 09 2015 - 15:41:59 EST


On Sat, Mar 07, 2015 at 09:08:46PM +0000, Al Viro wrote:
> POLL_OUT isn't what callers of ->poll() are expecting to see; it's
> actually __SI_POLL | 2 and it's a siginfo code, not a poll bitmap
> bit...

Thanks!--b.

>
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> ---
> diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
> index 33fb105..5199bb1 100644
> --- a/net/sunrpc/cache.c
> +++ b/net/sunrpc/cache.c
> @@ -921,7 +921,7 @@ static unsigned int cache_poll(struct file *filp, poll_table *wait,
> poll_wait(filp, &queue_wait, wait);
>
> /* alway allow write */
> - mask = POLL_OUT | POLLWRNORM;
> + mask = POLLOUT | POLLWRNORM;
>
> if (!rp)
> return mask;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/