Re: [PATCH] x86, selftests: Add sigreturn_32 selftest

[Andy Lutomirski]

On Mon, Mar 9, 2015 at 9:29 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> * Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:
>
>> This is my sigreturn test, added mostly unchanged from its old home.
>>
>> The integration with the selftest build process seems okay if not
>> particularly elegant.
>>
>> I'm not using the ksft_ helpers at all yet.  I can do that later.
>
> Cool!
>
> Doesn't seem to build on Ubuntu though:
>
> make[1]: Entering directory
> '/home/mingo/tip/tools/testing/selftests/x86'
> gcc -m32 -o sigreturn_32 -O2 -g -std=gnu99 -pthread -Wall  sigreturn.c -lrt -ldl
> sigreturn.c:13:22: fatal error: sys/time.h: No such file or directory
>  #include <sys/time.h>
>                       ^
> compilation terminated.
> Makefile:18: recipe for target 'sigreturn_32' failed
>
> also, run_tests.sh probably wants to be executable?

I think it is:

diff --git a/tools/testing/selftests/x86/run_tests.sh
b/tools/testing/selftests/x86/run_tests.sh
new file mode 100755

>
> Thanks,
>
>         Ingo



-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/