Re: [PATCH v2 4/4] staging: sm750fb: fix undeclared function

From: Dan Carpenter
Date: Mon Mar 09 2015 - 09:29:37 EST


On Mon, Mar 09, 2015 at 06:25:03PM +0530, Sudip Mukherjee wrote:
> Actually I thought, since this is a vendor crude driver there will be many such changes, so if i can combine some changes together then atleast the number of patches can be kept low and also i thought of clubbing these changes together as Joe Perches once told me "Don't get carried away with patch type separation" (reference: https://lkml.org/lkml/2015/1/1/2).

How to break up patches is more art than science. I wouldn't have
complained about the minor extra white space changes except that I was
already going to email you about breaking my scripts.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/