Re: [PATCH v4 2/2] cgroups: add a pids subsystem

From: Tejun Heo
Date: Sun Mar 08 2015 - 23:39:55 EST


On Sun, Mar 08, 2015 at 11:34:05PM -0400, Tejun Heo wrote:
> > + for (p = pids; p; p = p->parent) {
> > + long new;
> > +
> > + new = atomic_long_add_return(num, &p->counter);
> > +
> > + if (p->limit == PIDS_UNLIMITED)
> > + continue;
>
> Huh? So, the counter stays out of sync if unlimited? What happens
> when it gets set to something else later?

Oops, I misread the code, but why is PIDS_UNLIMITED a special case?
Just make it a number which always makes the condition true?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/