Re: [PATCH 01/19] selftests/timers: Cleanup Makefile to make it easier to add future tests

[Shuah Khan]

On 02/25/2015 03:32 PM, John Stultz wrote:
> Try to streamline the makefile so its easier to add timer/timekeeping
> tests.
> 
> Cc: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
> Cc: Prarit Bhargava <prarit@xxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Richard Cochran <richardcochran@xxxxxxxxx>
> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
> ---
>  tools/testing/selftests/timers/Makefile | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile
> index eb2859f..90a37b3 100644
> --- a/tools/testing/selftests/timers/Makefile
> +++ b/tools/testing/selftests/timers/Makefile
> @@ -1,8 +1,11 @@
> -all:
> -	gcc posix_timers.c -o posix_timers -lrt
> +CFLAGS += -O3 -Wl,-no-as-needed
> +LDFLAGS += -lrt -lpthread
> +bins = posix_timers
> +
> +all: ${bins}
>  
>  run_tests: all
>  	./posix_timers

Please add another target for running destructive
tests. You might have to classify tests so posix_timers
doesn't run all of them by default.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/