Re: [rtc-linux] [PATCH v3] rtc: s5m: Add the support for S2MPS13 RTC
From: Chanwoo Choi
Date: Tue Feb 24 2015 - 03:43:57 EST
On 02/24/2015 05:21 PM, Krzysztof Kozlowski wrote:
> 2015-02-24 7:09 GMT+01:00 Chanwoo Choi <cw00.choi@xxxxxxxxxxx>:
>> This patch adds only the compatible string for S2MPS13 clock which is identical
>> with S2MPS14 clock driver.
>
> If everything is identical then maybe use the same ID?
> { "s5m-rtc", S5M8767X },
> + { "s2mps13-rtc", S2MPS14X },
> { "s2mps14-rtc", S2MPS14X },
>
> Or in mfd/sec-core:
> static const struct mfd_cell s2mps13_devs[] = {
> - { .name = "s2mps13-rtc", },
> + { .name = "s2mps14-rtc", },
>
> The duplication of all S2MPS14 labels seems not necessary in such case.
OK, I agree, I'll send patch according to your comment.
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/