Re: [PATCH v2 1/1] clkdev: change prototype of clk_register_clkdev()

[Andy Shevchenko]

On Mon, 2015-02-23 at 11:53 +0000, Lee Jones wrote:
> On Mon, 23 Feb 2015, Andy Shevchenko wrote:
> 
> > Since clk_register_clkdev() is exported for modules the caller should get a
> > pointer to the allocated resources. Otherwise the memory leak is guaranteed on
> > the ->remove() stage.
> > 
> > Cc: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>
> > Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> >  arch/arm/mach-msm/clock-pcom.c         |  9 +++++----
> >  arch/arm/mach-vexpress/spc.c           |  5 ++++-
> >  arch/mips/ath79/clock.c                |  6 +++---
> >  drivers/clk/clk-bcm2835.c              | 12 +++++++-----
> >  drivers/clk/clk-max-gen.c              |  9 ++++-----
> >  drivers/clk/clk-xgene.c                |  6 +++---
> >  drivers/clk/clkdev.c                   | 15 ++++++++++-----
> >  drivers/clk/samsung/clk-pll.c          | 13 ++++++++-----
> >  drivers/clk/samsung/clk-s3c2410-dclk.c | 19 +++++++++---------
> >  drivers/clk/samsung/clk.c              | 35 +++++++++++++++++++---------------
> >  include/linux/clkdev.h                 |  2 +-
> >  11 files changed, 75 insertions(+), 56 deletions(-)
> 
> What's tying all of these changes together?  It would be better
> (simpler for you) if you split them up by subsystem and resubmitted.

In that case it will break bisectability.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/