Re: [PATCH 5/6] ASoC: samsung: Extend Snow driver to support max98089

From: Mark Brown
Date: Thu Feb 19 2015 - 04:45:31 EST


On Wed, Feb 18, 2015 at 07:25:58PM +0100, Andreas Färber wrote:

> static const struct of_device_id snow_of_match[] = {
> + { .compatible = "google,snow-audio-max98089", },
> { .compatible = "google,snow-audio-max98090", },
> { .compatible = "google,snow-audio-max98091", },
> { .compatible = "google,snow-audio-max98095", },

Since we completely ignore the CODEC in the property might it not be
better to just add a plain old snow-audio compatible and bind to that,
that way we don't need these driver updates? Just the "snow" bit should
be enough to know it's one of this class of machines.

Attachment: signature.asc
Description: Digital signature