Re: [PATCH] HID: wacom: do not directly use input_mt_report_pointer_emulation

From: Jiri Kosina
Date: Wed Feb 18 2015 - 17:43:59 EST


On Tue, 17 Feb 2015, Benjamin Tissoires wrote:

> On Tue, Feb 17, 2015 at 5:36 PM, Ping Cheng <pinglinux@xxxxxxxxx> wrote:
> > On Tue, Feb 17, 2015 at 11:19 AM, Benjamin Tissoires
> > <benjamin.tissoires@xxxxxxxxxx> wrote:
> >> input_mt_sync_frame() calls input_mt_report_pointer_emulation() and do
> >> some internal steps required to keep in sync the state of the touch within
> >> the various reports.
> >>
> >> Given that we use input_mt_assign_slot() in this driver, it is better to
> >> use input_mt_sync_frame().
> >
> > It is sensible to me, except I think you meant input_mt_slot() instead
> > of input_mt_assign_slot().
>
> Hehe, I should have actually checked the call. I meant
> input_mt_get_slot_by_key().
>
> >
> >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
> >
> > Reviewed-by: Ping Cheng <pingc@xxxxxxxxx>

Applied (with adjusted changelog).

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/