Re: [PATCH 1/4] mm: cma: add currently allocated CMA buffers list to debugfs

[Stefan Strogin]

Hello SeongJae,

On 13/02/15 17:18, SeongJae Park wrote:
> Hello, Stefan.
> 
> On Fri, 13 Feb 2015, Stefan Strogin wrote:
> 
>> #include <linux/io.h>
>> +#include <linux/list.h>
>> +#include <linux/proc_fs.h>
>> +#include <linux/time.h>
> 
> Looks like `proc_fs.h` and `time.h` are not necessary.
> 

Yes, of course. Thanks.


>> +        pr_warn("%s(page %p, count %d): failed to allocate buffer
>> list entry\n",
>> +            __func__, pfn_to_page(pfn), count);
> 
> pfn_to_page() would cause build failure on x86_64. Why don't you include
> appropriate header file?
> 

Indeed. Because I tested it only on arm and x86. Sorry :( Thank you.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/