Re: [PATCH] rtlwifi: ratelimit skb allocation failure message

[Eric Dumazet]

On Tue, 2015-02-10 at 08:54 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> when running low on memory I noticed rtlwifi was producing a large
> quantity of repeated skb allocation failures messages.  This should
> be ratelimited to reduce the noise.
> 
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  drivers/net/wireless/rtlwifi/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
> index c70efb9..ca0fd50 100644
> --- a/drivers/net/wireless/rtlwifi/pci.c
> +++ b/drivers/net/wireless/rtlwifi/pci.c
> @@ -817,7 +817,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
>  		/* get a new skb - if fail, old one will be reused */
>  		new_skb = dev_alloc_skb(rtlpci->rxbuffersize);
>  		if (unlikely(!new_skb)) {
> -			pr_err("Allocation of new skb failed in %s\n",
> +			pr_err_ratelimited("Allocation of new skb failed in %s\n",
>  			       __func__);

Or even better, remove the message.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/