Re: [PATCH] staging: lustre: lnet: lnet: lip-ptl:fix sparse warning of static declaration

From: Joe Perches
Date: Mon Feb 09 2015 - 11:29:40 EST


On Mon, 2015-02-09 at 21:45 +0530, Mohammad Jamal wrote:
> This patch adds a static keyword to variable portal_rotor to
> suppress the sparse warning of static declaration

Do please compile the subsystem before sending patches.

> diff --git a/drivers/staging/lustre/lnet/lnet/lib-ptl.c b/drivers/staging/lustre/lnet/lnet/lib-ptl.c
[]
> @@ -39,7 +39,7 @@
> #include "../../include/linux/lnet/lib-lnet.h"
>
> /* NB: add /proc interfaces in upcoming patches */
> -int portal_rotor = LNET_PTL_ROTOR_HASH_RT;
> +static int portal_rotor = LNET_PTL_ROTOR_HASH_RT;
> module_param(portal_rotor, int, 0644);
> MODULE_PARM_DESC(portal_rotor, "redirect PUTs to different cpu-partitions");

$ git grep -w portal_rotor
...
drivers/staging/lustre/lnet/lnet/router_proc.c:extern int portal_rotor;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/