Re: [PATCH v2 1/2] mtd: nand: pxa3xx: Fix PIO FIFO draining

[Maxime Ripard]

On Fri, Feb 06, 2015 at 11:38:59AM -0800, Brian Norris wrote:
> > > An alternative would be to move this part into the read/write_buf
> > > functions, but that's a lot of work...
> > > 
> > 
> > Yeah, indeed. This also has other benefits. As we discussed on IRC, it
> > would allow to support raw writes (i.e. ECC off).
> 
> OK. This is probably a good work item for later. But let's get back on
> point.
> 
> I'd like to see version 2 with the following:
> 
> 1. For sure the jiffies loop needs to be rewritten
> 
> 2. Optionally, the RDDREQ bit should be checked less often, per the
>    datasheet and Boris's comments
> 
> Maxime, would that be OK?

Yep. I actually worked on these two issues just today.

It looks like I blew my boards' bootloader in the process, so it might
take so time.

> Then maybe I can get this into 3.20. Maybe not in my primary -rc1
> pullreq, if we haven't had enough time to look at and test v2, but ASAP.
> Only after than am I likely to take Rob's ARM64 cleanup.

Sounds good, thanks!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Attachment: signature.asc
Description: Digital signature