Re: [PATCH] media: i2c: ADV7604: Rename adv7604 prefixes.

From: Hans Verkuil
Date: Wed Feb 04 2015 - 04:55:50 EST


On 02/03/15 18:13, Pablo Anton wrote:
> It is confusing which parts of the driver are adv7604 specific, adv7611 specific or common for both.
> This patch renames any adv7604 prefixes (both for functions and defines) to adv76xx whenever they are common.
>
> Signed-off-by: Pablo Anton <pablo.anton@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jean-Michel Hautbois <jean-michel.hautbois@xxxxxxxxxxx>

I'm happy with this, except for three small changes:

- I had to rebase
- ADV76xx_fsc should be ADV76XX_FSC
- The driver name should stay the same to keep in sync with the module name.
Besides, we might have a future driver for the adv7622/3, so adv76xx as the
driver name is potentially confusing.

I've applied these changes and the updated patch is below. If possible I
would like to get this in 3.20 so future patches for 3.21 can all be based
on these renamed functions/defines.

Acks from Lars and Laurent would be welcome, though.

Regards,

Hans