Re: [PATCH] ath9k_htc: add adaptive usb flow control to repair soft lockup with monitor mode

From: Kalle Valo
Date: Tue Feb 03 2015 - 06:52:46 EST


yuweizheng@xxxxxxx writes:

> From: Yuwei Zheng <yuweizheng@xxxxxxx>
>
> In the environment with heavy wifi traffic, set the ar9271 into monitor mode, will
> trigger a deadloop panic.
>
> The ath9k_hif_usb_rx_cb function excute on the interrupt context, and ath9k_rx_tasklet excute
> on the soft irq context. In other words, the ath9k_hif_usb_rx_cb have more chance to excute than
> ath9k_rx_tasklet. So in the worst condition, the rx.rxbuf receive list is always full,
> and the do {}while(true) loop will not be break. The kernel get a soft lockup panic.

The word wrapping is still wrong, please limit the width to 72 chars or
so. But no need to wrap log snippets, they can exceed the limit.

> Signed-off-by: Yuwei Zheng <zhengyuwei@xxxxxx>
> Signed-off-by: Yuwei Zheng <yuweizheng@xxxxxxx>

Why two of these? Please use just one Signed-off-by line. Unless these
are two different persons with the same name :)

--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/