Re: [PATCH v2 00/15] media: blackfin: bfin_capture enhancements

From: Scott Jiang
Date: Tue Feb 03 2015 - 03:09:35 EST


Hi Hans,


>> On Thu, Jan 22, 2015 at 10:18 PM, Lad, Prabhakar
>> <prabhakar.csengg@xxxxxxxxx> wrote:
>>> This patch series, enhances blackfin capture driver with
>>> vb2 helpers.
>>>
>>> Changes for v2:
>>> --------------
>>> Only patches 5/15 and 8/15 as per Scott's suggestions.
>>>
>>> Lad, Prabhakar (15):
>>> media: blackfin: bfin_capture: drop buf_init() callback
>>> media: blackfin: bfin_capture: release buffers in case
>>> start_streaming() call back fails
>>> media: blackfin: bfin_capture: set min_buffers_needed
>>> media: blackfin: bfin_capture: improve buf_prepare() callback
>>> media: blackfin: bfin_capture: improve queue_setup() callback
>>> media: blackfin: bfin_capture: use vb2_fop_mmap/poll
>>> media: blackfin: bfin_capture: use v4l2_fh_open and vb2_fop_release
>>> media: blackfin: bfin_capture: use vb2_ioctl_* helpers
>>> media: blackfin: bfin_capture: make sure all buffers are returned on
>>> stop_streaming() callback
>>> media: blackfin: bfin_capture: return -ENODATA for *std calls
>>> media: blackfin: bfin_capture: return -ENODATA for *dv_timings calls
>>> media: blackfin: bfin_capture: add support for vidioc_create_bufs
>>> media: blackfin: bfin_capture: add support for VB2_DMABUF
>>> media: blackfin: bfin_capture: add support for VIDIOC_EXPBUF
>>> media: blackfin: bfin_capture: set v4l2 buffer sequence
>>>
>>> drivers/media/platform/blackfin/bfin_capture.c | 311 ++++++++-----------------
>>> 1 file changed, 99 insertions(+), 212 deletions(-)
>>>
>> Can you ACK the series ? so that its easier for Hans to pick it up.
>
> ping!
>
> Scott, I can't take it unless you Ack it. Actually, I'd like to see a
> 'Tested-by' tag.
>
One patch has problem, I have modified this patch and tested it.

> And if you are testing anyway, then I would really like to see the output
> of 'v4l2-compliance -s', using the v4l2-compliance from the latest v4l-utils.git.
>
> I'm curious to see the results of that.
>
v4l2-utils can't be compiled under uClibc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/