Re: [PATCH 3/3] iio: ad_sigma_delta: cleanup wait_for_completion return handling

From: Lars-Peter Clausen
Date: Mon Feb 02 2015 - 04:41:41 EST


On 02/02/2015 09:37 AM, Nicholas Mc Guire wrote:
return type of wait_for_completion_timeout is unsigned long not int, rather
than introducing a new variable the wait_for_completion_timeout is moved
into the if condition as the return value is only used to detect timeout.

But the return value is bound by the timeout parameter and we know that fits into a int. And I really dont like moving the function call into the if condition, so unless there is some additional explanation why this is necessary and should be done I'm inclined to nack this.


Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
---

Aside from the fixup of the wait_for_completion_timeout handling
a minor coding style issue in the else branch was fixed - the {} is
not needed for the one-line body.

If one of the branches of a conditional statement has braces the other branches should also have braces. This is documented in Documentation/CodingStyle.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/