Re: [PATCH] staging: rtl8723au: core: rtw_mlme: Removed variables that is never used

[Rickard Strandqvist]

2015-02-02 0:02 GMT+01:00 Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>:
> Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> writes:
>> Variable was assigned a value that was never used.
>> I have also removed all the code that thereby serves no purpose.
>>
>> This was found using a static code analysis program called cppcheck
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>
>> ---
>>  drivers/staging/rtl8723au/core/rtw_mlme.c |   21 ++++++++++-----------
>>  1 file changed, 10 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c
>> index 7299ef0..8b2db4b 100644
>> --- a/drivers/staging/rtl8723au/core/rtw_mlme.c
>> +++ b/drivers/staging/rtl8723au/core/rtw_mlme.c
>> @@ -2123,7 +2123,6 @@ bool rtw_restructure_ht_ie23a(struct rtw_adapter *padapter, u8 *in_ie,
>>  {
>>       u32 out_len;
>>       int max_rx_ampdu_factor;
>> -     unsigned char *pframe;
>>       const u8 *p;
>>       struct ieee80211_ht_cap ht_capie;
>>       u8 WMM_IE[7] = {0x00, 0x50, 0xf2, 0x02, 0x00, 0x01, 0x00};
>> @@ -2139,10 +2138,10 @@ bool rtw_restructure_ht_ie23a(struct rtw_adapter *padapter, u8 *in_ie,
>>
>>               if (pmlmepriv->qos_option == 0) {
>>                       out_len = *pout_len;
>> -                     pframe = rtw_set_ie23a(out_ie + out_len,
>> -                                            WLAN_EID_VENDOR_SPECIFIC,
>> -                                            sizeof(WMM_IE), WMM_IE,
>> -                                            pout_len);
>> +                     rtw_set_ie23a(out_ie + out_len,
>> +                                             WLAN_EID_VENDOR_SPECIFIC,
>> +                                             sizeof(WMM_IE), WMM_IE,
>> +                                             pout_len);
>
> And again here - do it properly, please.
>
> Jes

Hi Jes

I am sorry, please ignore this.
I will not send any more patches.

Kind regards
Rickard Strandqvist
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/