Re: checkpatch: length of git commit IDs

From: Stefan Richter
Date: Sun Feb 01 2015 - 15:30:22 EST


On Feb 01 Joe Perches wrote:
> On Sun, 2015-02-01 at 20:59 +0100, Stefan Richter wrote:
> > I was just told that 12 is less than 12:
> >
> > > ERROR: Please use 12 or more chars for the git commit ID like: 'Commit
> > > 01234567890ab ("commit description")' #5:
> > > Commit 2a48fc0ab242 "block: autoconvert trivial BKL users to private
>
> Yeah, that message isn't very descriptive.
>
> It really wants parentheses around the commit
> message like:
>
> Commit 2a48fc0ab242 ("block: autoconvert trivial BKL users to private
>
> Try the version in -next. I think it has a
> better message description.

Thanks for the tip; this works for me. (checkpatch.pl from current -next
does actually not complain about the line without parentheses.)
--
Stefan Richter
-=====-===== --=- ----=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/