Re: [PATCH] mm: compaction: fix the page state calculation in too_many_isolated

From: Vlastimil Babka
Date: Thu Jan 22 2015 - 10:38:50 EST


On 01/22/2015 01:58 AM, David Rientjes wrote:
I think in case of async compaction, we could skip the safe stuff and just
terminate it - it's already done when too_many_isolated returns true, and
there's no congestion waiting in that case.

So you could extend the too_many_isolated() with "safe" parameter (as you did
for vmscan) and pass it "cc->mode != MIGRATE_ASYNC" value from
isolate_migrate_block().


Or just pass it struct compact_control *cc and use both cc->zone and
cc->mode inside this compaction-only function.

Yeah,

in any case, please wait until the discussion about the vmscan fix is resolved, before reposting this.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/