Re: [rtc-linux] [PATCH] rtc: s5m: terminate s5m_rtc_id array with empty element

From: Krzysztof Kozlowski
Date: Thu Jan 22 2015 - 04:37:38 EST


2015-01-21 16:06 GMT+01:00 Andrey Ryabinin <a.ryabinin@xxxxxxxxxxx>:
> Array of platform_device_id elements should be terminated
> with empty element.
>
> Signed-off-by: Andrey Ryabinin <a.ryabinin@xxxxxxxxxxx>
> ---
> drivers/rtc/rtc-s5m.c | 1 +
> 1 file changed, 1 insertion(+)


Right, good catch.

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>

Maybe also cc stable for fixing 5bccae6ec458 ("rtc: s5m-rtc: add
real-time clock driver for s5m8767")?

Best regards,
Krzysztof

>
> diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
> index b5e7c46..89ac1d5 100644
> --- a/drivers/rtc/rtc-s5m.c
> +++ b/drivers/rtc/rtc-s5m.c
> @@ -832,6 +832,7 @@ static SIMPLE_DEV_PM_OPS(s5m_rtc_pm_ops, s5m_rtc_suspend, s5m_rtc_resume);
> static const struct platform_device_id s5m_rtc_id[] = {
> { "s5m-rtc", S5M8767X },
> { "s2mps14-rtc", S2MPS14X },
> + { },
> };
>
> static struct platform_driver s5m_rtc_driver = {
> --
> 2.2.1
>
> --
> --
> You received this message because you are subscribed to "rtc-linux".
> Membership options at http://groups.google.com/group/rtc-linux .
> Please read http://groups.google.com/group/rtc-linux/web/checklist
> before submitting a driver.
> ---
> You received this message because you are subscribed to the Google Groups "rtc-linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@xxxxxxxxxxxxxxxxx
> For more options, visit https://groups.google.com/d/optout.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/