Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

From: Lee Jones
Date: Tue Jan 20 2015 - 11:55:39 EST


On Tue, 20 Jan 2015, Javier Martinez Canillas wrote:

> Hello Lee,
>
> On 01/20/2015 05:29 PM, Lee Jones wrote:
> >
> > It's not a blocker, but it is a ridiculous name to use inside the
> > driver/ directory 'cos almost everything is a dev(ice) here.
> >
>
> Right, do you think that "cros-ec-chardev" will be a more suitable
> name? Sorry, I'm really bad at naming things...

But is it really a chardev? Don't chardevs usually live in
drivers/char? It probably uses a chardev node in /dev, but what does
it really do? What information can/will userspace obtain from this
memory block?

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/