Re: [PATCH v5 4/5] mfd/regulator: dt-bindings: max77686: Document gpio properties

From: Krzysztof Kozlowski
Date: Tue Jan 20 2015 - 09:21:53 EST


On wto, 2015-01-20 at 13:41 +0000, Lee Jones wrote:
> On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote:
>
> > Document usage of maxim,ena-gpios properties which turn on external/GPIO
> > control over regulator.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/mfd/max77686.txt | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/max77686.txt b/Documentation/devicetree/bindings/mfd/max77686.txt
> > index 75fdfaf41831..e39f0bc1f55e 100644
> > --- a/Documentation/devicetree/bindings/mfd/max77686.txt
> > +++ b/Documentation/devicetree/bindings/mfd/max77686.txt
> > @@ -39,6 +39,12 @@ to get matched with their hardware counterparts as follow:
> > -BUCKn : 1-4.
> > Use standard regulator bindings for it ('regulator-off-in-suspend').
> >
> > + LDO20, LDO21, LDO22, BUCK8 and BUCK9 can be configured to GPIO enable
> > + control. To turn this feature on this property must be added to the regulator
> > + sub-node:
> > + - maxim,ena-gpios : one GPIO specifier enable control (the gpio
> > + flags are actually ignored and always
> > + ACTIVE_HIGH is used)
>
> How does this differ to the 'enable-gpio' property which has already
> been defined?

Strictly speaking - no difference, just a GPIO specifier.

However the 'enable-gpio' property exists only for gpio-regulator. The
regulator core does not support generic enable-gpio property and each
driver implements it on its own.

Anyway Mark Brown already applied this patch to his regulator tree.

Best regards,
Krzysztof

>
> > Example:
> >
> > @@ -65,4 +71,12 @@ Example:
> > regulator-always-on;
> > regulator-boot-on;
> > };
> > +
> > + buck9_reg {
> > + regulator-compatible = "BUCK9";
> > + regulator-name = "CAM_ISP_CORE_1.2V";
> > + regulator-min-microvolt = <1000000>;
> > + regulator-max-microvolt = <1200000>;
> > + maxim,ena-gpios = <&gpm0 3 GPIO_ACTIVE_HIGH>;
> > + };
> > }
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/