Re: perf fuzzer crash [PATCH] perf: Get group events reference before moving the group

From: Vince Weaver
Date: Fri Jan 16 2015 - 13:54:19 EST


On Fri, 16 Jan 2015, Peter Zijlstra wrote:
> On Fri, Jan 16, 2015 at 11:46:44AM +0100, Peter Zijlstra wrote:
> > Its a bandaid at best :/ The problem is (again) that we changes
> > event->ctx without any kind of serialization.
> >
> > The issue came up before:
> >
> > https://lkml.org/lkml/2014/9/5/397
> >
> > and I've not been able to come up with anything much saner.
>
> A little something like the below is the best I could come up with; I
> know Linus hated it, but I figure we ought to do something to stop
> crashing.

I just wanted to report that I've tested both this patch and Jiri's
original one and they both keep my easy-to-trigger-testcase from crashing
my core2 machine (when applied against 3.18).

This is great! I've been chasing this bug for months.

Vince
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/