Issue with 'lib/vsprintf.c: don't try to fix pointer wrap-around'

From: Johannes Weiner
Date: Fri Jan 16 2015 - 11:24:10 EST


Hi Rasmus,

I have trouble booting my test machine with this patch in -mm:

commit bb2e066c6943e62e9650bb129f416dacf138f8b1
Author: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
Date: Wed Jan 14 01:00:44 2015 +0000

lib/vsprintf.c: don't try to fix pointer wrap-around

Actual kernel buffers can't wrap into the user address space. If someone
manages to pass a buf/size combination that wraps, it is most likely due
to a bug in the caller. Instead of trying to fix it by using a smaller
part of the buffer, bail out.

Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
Cc: Jiri Kosina <jkosina@xxxxxxx>
Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

After I get "Loading bzImage-new... ok" from the bootloader, the
serial console remains quiet.

A WARN_ON_ONCE() inside vsnprintf() looks like it would deadlock
instantly when triggering this overflow from printk(), no?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/