Re: [PATCH] drm/radeon/radeon_i2c: Remove unused function

From: Alex Deucher
Date: Wed Jan 14 2015 - 16:44:31 EST


On Tue, Jan 13, 2015 at 2:09 PM, Rickard Strandqvist
<rickard_strandqvist@xxxxxxxxxxxxxxxxxx> wrote:
> Remove the function radeon_best_encoder() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>

Applied. thanks!

Alex

> ---
> drivers/gpu/drm/radeon/radeon_i2c.c | 5 -----
> drivers/gpu/drm/radeon/radeon_mode.h | 2 --
> 2 files changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c
> index add6220..9590bcd 100644
> --- a/drivers/gpu/drm/radeon/radeon_i2c.c
> +++ b/drivers/gpu/drm/radeon/radeon_i2c.c
> @@ -1048,11 +1048,6 @@ struct radeon_i2c_chan *radeon_i2c_lookup(struct radeon_device *rdev,
> return NULL;
> }
>
> -struct drm_encoder *radeon_best_encoder(struct drm_connector *connector)
> -{
> - return NULL;
> -}
> -
> void radeon_i2c_get_byte(struct radeon_i2c_chan *i2c_bus,
> u8 slave_addr,
> u8 addr,
> diff --git a/drivers/gpu/drm/radeon/radeon_mode.h b/drivers/gpu/drm/radeon/radeon_mode.h
> index 04db2fd..66c17e3 100644
> --- a/drivers/gpu/drm/radeon/radeon_mode.h
> +++ b/drivers/gpu/drm/radeon/radeon_mode.h
> @@ -740,8 +740,6 @@ extern void radeon_router_select_ddc_port(struct radeon_connector *radeon_connec
> extern void radeon_router_select_cd_port(struct radeon_connector *radeon_connector);
> extern bool radeon_ddc_probe(struct radeon_connector *radeon_connector, bool use_aux);
>
> -extern struct drm_encoder *radeon_best_encoder(struct drm_connector *connector);
> -
> extern bool radeon_atombios_get_ppll_ss_info(struct radeon_device *rdev,
> struct radeon_atom_ss *ss,
> int id);
> --
> 1.7.10.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/