Re: [PATCH 5/7] perf tools: Pass struct perf_hpp_fmt to its callbacks

From: Arnaldo Carvalho de Melo
Date: Mon Jan 12 2015 - 11:21:50 EST


Em Thu, Jan 08, 2015 at 09:45:46AM +0900, Namhyung Kim escreveu:
> Currently ->cmp, ->collapse and ->sort callbacks doesn't pass
> corresponding fmt. But it'll be needed by upcoming changes in
> perf diff command.
>
> Suggested-by: Jiri Olsa <jolsa@xxxxxxxxxx>


CC /tmp/build/perf/builtin-evlist.o
builtin-diff.c: In function âdata__hpp_registerâ:
builtin-diff.c:1036:11: error: assignment from incompatible pointer type [-Werror]
fmt->cmp = hist_entry__cmp_nop;
^
builtin-diff.c:1037:16: error: assignment from incompatible pointer type [-Werror]
fmt->collapse = hist_entry__cmp_nop;
^
builtin-diff.c:1043:13: error: assignment from incompatible pointer type [-Werror]
fmt->sort = hist_entry__cmp_baseline;
^
builtin-diff.c:1047:13: error: assignment from incompatible pointer type [-Werror]
fmt->sort = hist_entry__cmp_delta;
^
builtin-diff.c:1051:13: error: assignment from incompatible pointer type [-Werror]
fmt->sort = hist_entry__cmp_ratio;
^
builtin-diff.c:1055:13: error: assignment from incompatible pointer type [-Werror]
fmt->sort = hist_entry__cmp_wdiff;
^
builtin-diff.c:1058:13: error: assignment from incompatible pointer type [-Werror]
fmt->sort = hist_entry__cmp_nop;
^
cc1: all warnings being treated as errors
LINK plugin_kvm.so
make[1]: *** [/tmp/build/perf/builtin-diff.o] Error 1
make[1]: *** Waiting for unfinished jobs....
LINK plugin_mac80211.so

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/