Re: [PATCH 00/25] line6usb cleanup

From: Stefan Hajnoczi
Date: Sat Jan 10 2015 - 03:49:19 EST


On Sat, Jan 10, 2015 at 5:35 AM, Chris Rorvick <chris@xxxxxxxxxxx> wrote:
> The line6usb driver references the device's idProduct and, in some
> cases, the interface number in a number of places to determine device-
> specific configuration values and to call device-specific functionality.
> Rework code to leverage the device table matching more effectively.
> Consolidate configuration settings into the properties entries and use
> function pointers setup at initialization to remove much of the
> conditional logic.
>
> I have a TonePort UX2 that I've used for testing, meaning that some of
> this is really only compile-tested.

I no longer own a Pod HD300 so I cannot test these patches. The code
looks fine.

Reviewed-by: Stefan Hajnoczi <stefanha@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/